Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of distutils #1883

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Remove use of distutils #1883

merged 1 commit into from
Sep 22, 2021

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Sep 21, 2021

Rationale

Python has deprecated distutils and will be removing it in 3.12 (supposedly).

Implications

No warnings with Python 3.10.

@QuLogic QuLogic added this to the 0.20.1 milestone Sep 21, 2021
stickler-ci
stickler-ci reviewed Sep 21, 2021
View reviewed changes
setup.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
greglucas
greglucas approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add an ignore clause for Stickler to ignore import warnings on setup.py

@greglucas greglucas merged commit 867af19 into SciTools:master Sep 22, 2021
@QuLogic QuLogic deleted the no-distutils branch September 22, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stickler-ci stickler-ci stickler-ci left review comments

@greglucas greglucas greglucas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.20.1
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @greglucas @stickler-ci